This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [cplus] Add an entry point for cp-names


> Date: Wed, 24 Dec 2003 17:36:16 -0500
> From: Daniel Jacobowitz <drow@mvista.com>
> 
> 2003-12-24  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* Makefile.in (cp_names_h): New variable.
> 	(cp-names.tab.o, cp-names-main.tab.o): Depend on cp-names.h.

Just a reminder: the *.tab.c files need entries in fnchange.lst to
rename them to *_tab.c.  So these two files will need two additional
lines.

Actually, there's more to this: cp-names_tab.c and cp-names-main_tab.c
map to the same 8+3 DOS name, so they will break the script in
gdb/config/djgpp/djconfig.sh which accounts for renaming of *.tab.c
files (see config.sed for the gory details).  Thus, please consider
some other name for cp-names-main.tab.c, one that doesn't conflict
with cp-names.tab.c.

> +cp-names-main.tab.o: cp-names.tab.c $(safe_ctype_h) $(cp_names_h) \
>  	$(srcdir)/../libiberty/cp-demangle.c
>  	$(CC) -c $(INTERNAL_CFLAGS) -DTEST_CPNAMES \
>  		-o cp-names-main.tab.o cp-names.tab.c

Nitpicking: I find this formatting of continuation lines confusing:
the continuation of the list of prerequisites is indented exactly as
the rule's command, so it looks like the first command in a rule.
(Yes, I know: there are other rules indented like that; if no one
objects, I will reindent them so that commands stand out more
clearly.)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]