This is the mail archive of the
mailing list for the GDB project.
Re: [RFA]: Fix do_cleanups if oldchain is NULL
- From: Andrew Cagney <cagney at gnu dot org>
- To: Jeff Johnston <jjohnstn at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 02 Jan 2004 11:06:49 -0500
- Subject: Re: [RFA]: Fix do_cleanups if oldchain is NULL
- References: <3FE0C502.firstname.lastname@example.org>
I recently solved a bug on the ia64 concerning cleanups. What was happening was that a cleanup list was being re-initialized to NULL inside a loop and later do_cleanups() was called. This caused the entire cleanup list to be run because the design is to run the list until the passed in cleanup is reached. This caused other errors when the stream being used was deleted, etc...
This patch adds a check to do_my_cleanups() so no cleanups will be performed if the passed in chain is NULL.
Ok to commit?
(hmm, no one thought to review this while I was on hols :-()
I think the bug is in the calling code, and not utils.c. That patch
unfortunatly makes a fundamental change to the core of the cleanup code
and there's no easy way of demonstrating that other callers aren't
assuming that NULL implies do all cleanups.
-- Jeff J.
2003-12-17 Jeff Johnston <email@example.com>
* utils.c (do_my_cleanups): Don't do cleanups if old chain
passed in is NULL.