Re: RFA: New regression test for breakpoint command freeing

[Jim Blandy <jimb at redhat dot com>]

mec.gnu@mindspring.com (Michael Elizabeth Chastain) writes:
> Is there a PR for this bug?  If not, can you file one?  Then change the
> FAIL's to KFAIL's with the PR number on it.  That way I can tell the
> "Invalid control type" from truly unexpected bugs.

I posted the fix when I posted the test.  To make sure things are
tracked properly until the review is done, I've filed gdb/1489, and
committed the first attached patch to make it a kfail.

2003-12-17  Jim Blandy  <jimb@redhat.com>

	* gdb.base/freebpcmd.exp: Mark the interesting failure as known.

Index: gdb/testsuite/gdb.base/freebpcmd.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/freebpcmd.exp,v
retrieving revision 1.1
diff -c -r1.1 freebpcmd.exp
*** gdb/testsuite/gdb.base/freebpcmd.exp	13 Dec 2003 20:12:31 -0000	1.1
--- gdb/testsuite/gdb.base/freebpcmd.exp	17 Dec 2003 21:26:22 -0000
***************
*** 110,121 ****
  gdb_run_cmd
  gdb_test_multiple "" "run program with breakpoint commands" {
      -re "warning: Invalid control type in command structure" {
!         fail "run program with breakpoint commands"
      }
      -re "$gdb_prompt $" {
          pass "run program with breakpoint commands"
      }
      eof {
!         fail "run program with breakpoint commands (GDB died)"
      }
  }
--- 110,121 ----
  gdb_run_cmd
  gdb_test_multiple "" "run program with breakpoint commands" {
      -re "warning: Invalid control type in command structure" {
!         kfail "gdb/1489" "run program with breakpoint commands"
      }
      -re "$gdb_prompt $" {
          pass "run program with breakpoint commands"
      }
      eof {
!         kfail "gdb/1489" "run program with breakpoint commands (GDB died)"
      }
  }

> Also, freebpcmd.c needs a copyright notice.

Duh.  Thanks.  I've committed the second attached patch.

2003-12-17  Jim Blandy  <jimb@redhat.com>

	* gdb.base/freebpcmd.c: Add copyright notice.

Index: gdb/testsuite/gdb.base/freebpcmd.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/freebpcmd.c,v
retrieving revision 1.1
diff -c -r1.1 freebpcmd.c
*** gdb/testsuite/gdb.base/freebpcmd.c	13 Dec 2003 20:12:31 -0000	1.1
--- gdb/testsuite/gdb.base/freebpcmd.c	17 Dec 2003 21:32:08 -0000
***************
*** 1,3 ****
--- 1,23 ----
+ /* Test program for GDB crashes while doing bp commands that continue inferior.
+    Copyright 2003 Free Software Foundation, Inc.
+ 
+    This file is part of the gdb testsuite.
+ 
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+ 
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+ 
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 59 Temple Place - Suite 330,
+    Boston, MA 02111-1307, USA.  */
+ 
  int
  main (int argc, char **argv)
  {