This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] stabs: remember types that cross reference another type
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: Joel Brobecker <brobecker at gnat dot com>
- Cc: Elena Zannoni <ezannoni at redhat dot com>,gdb-patches at sources dot redhat dot com
- Date: Thu, 4 Dec 2003 19:27:58 -0500
- Subject: Re: [RFA] stabs: remember types that cross reference another type
- References: <20031031200851.GD1236@gnat.com><20031103225952.GA2412@gnat.com><16334.50206.868506.409948@localhost.redhat.com><20031205002258.GJ1652@gnat.com>
Joel Brobecker writes:
> > Yes, but the comment before that loop you are changing needs some
> > revamping. Reading it, it really looks like it is a useless/obsoleted
> > thing we are doing here, while now it's not the case anymore. I mean,
> > it is useful.
>
> yes, I agree. I am not sure how much information to keep though.
> Would the following be ok?
>
yep
elena
> /* If this type has already been declared, then reuse the same type
> rather than allocating a new one. This saves some memory. */
>
> The current comment is:
>
> /* Now check to see whether the type has already been
> declared. This was written for arrays of cross-referenced
> types before we had TYPE_CODE_TARGET_STUBBED, so I'm pretty
> sure it is not necessary anymore. But it might be a good
> idea, to save a little memory. */
>
> --
> Joel