This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, rfa:ppc64, rfa:breakpoint] Add non-verbose breakpointadjustment



For breakpoint.c, I've also modified the warnings so that the warning:

warning: Breakpoint 2 address previously adjusted from 0x104e5a60 to 0x100895d0.

no longer occures - I figure that the user will have noted it when the breakpoint was set. It could also be made per-breakpoint?


I would prefer that gdb issue warnings both at the time the breakpoint
was set and when it gets hit.  Or at least until we have more
experience with it and find that the second warning unduly annoys
users.

As a user, it annoyed me :-)


If you'd prefer I'll let PPC64 print both warnings as well.

How about calling gdbarch_adjust_breakpoint_address() to find out if
the second warning should be printed?  Alternately, we could add a
field to the breakpoint struct, but this seems like overkill.

Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]