This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [commit] target_open (target, ...)

From: Andrew Cagney <ac131313 at redhat dot com>
To: Daniel Jacobowitz <drow at mvista dot com>
Cc: gdb-patches at sources dot redhat dot com
Date: Wed, 22 Oct 2003 22:55:25 -0400
Subject: Re: [commit] target_open (target, ...)
References: <3F96F8E6.5000702@redhat.com> <20031023023607.GA2637@nevyn.them.org>

Wrong patch?  This is target_close, not target_open.  It also deletes
the target_open macro without adding a new target_open function.

No, a 180 description. s/target_open/target_close/. The _macro_ target_open() is _never_ called.

Please don't add 'x'.  There's nothing wrong with having a target_open
function which calls target_ops->to_open.

The vector already contains ->to_open and ->to_close methods so unless we've switched to C++, I can't add a second to_close.

Once the existing ->to_close is deprecated, I can rename ->to_xclose.

Andrew

Follow-Ups:
- Re: [commit] target_open (target, ...)
  - From: Daniel Jacobowitz

References:
- [commit] target_open (target, ...)
  - From: Andrew Cagney
- Re: [commit] target_open (target, ...)
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]