This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit] target_open (target, ...)
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 22 Oct 2003 22:36:07 -0400
- Subject: Re: [commit] target_open (target, ...)
- References: <3F96F8E6.5000702@redhat.com>
On Wed, Oct 22, 2003 at 05:38:46PM -0400, Andrew Cagney wrote:
> Hello,
>
> This patch adds "struct target_ops" to target_open (now a function), and
> a target vector method "to_xopen" that also takes a "struct target_ops".
>
> It then updates all the corresponding calls.
>
> committed,
> Andrew
> 2003-10-22 Andrew Cagney <cagney@redhat.com>
>
> * target.c (target_close): New function.
> (debug_to_close): Use "target_close".
> (push_target): Use "target_close".
> (unpush_target): Use "target_close".
> (pop_target): Use "target_close".
> * target.h (struct target_ops): Add "to_xclose".
> (target_open): Delete macro. Move comment to "to_open".
> (target_close): Replace macro with function that takes a target.
> * top.c (quit_target): Pass "current_target" to "target_close".
Wrong patch? This is target_close, not target_open. It also deletes
the target_open macro without adding a new target_open function.
Please don't add 'x'. There's nothing wrong with having a target_open
function which calls target_ops->to_open.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer