Re: [Patch] fix for PR:1291 (Ping Corinna)

["Kris Warkentin" <kewarken at qnx dot com>]

Howdy all,

Finally got around to building a head branch gdb with Corinna's sh4 work.
Excellent job.  The backtrace works perfectly now and renders my patch
redundant.  Someone can probably put this PR to fixed-test.

cheers,

Kris

----- Original Message ----- 
From: "Kris Warkentin" <kewarken@qnx.com>
To: "Elena Zannoni" <ezannoni@redhat.com>
Cc: <gdb-patches@sources.redhat.com>
Sent: Tuesday, September 23, 2003 9:21 PM
Subject: Re: [Patch] fix for PR:1291


> > kewarken writes:
> >  > Credit to inaba@src.ricoh.co.jp for his original find and patch and
to
> >  > Colin Burgess for noting the differences between gcc 2 and 3.
> >  >
> >  > ChangeLog:
> >  >
> >  > 2003-09-16  Kris Warkentin  <kewarken@qnx.com>
> >  >
> >  > * sh-tdep.c: Properly detect frame prologues for functions with
> >  > more than 256 bytes of local variables.
> >
> > You should give credit to these folks in the changelog entry.
>
> Certainly.
>
> > I wonder if this can be captured in a test case?  How does your change
> > interacts with Corinna's rewrite?
>
> I'll take a look at it when I have some more time next week.  The test
case
> is very simple so I can easily check to see if Corinna's stuff fixes it.
> Unfortunately my available gdb cycles have been extremely low lately since
> we have a lot of critical internal stuff that I've been grabbed for.
>
> cheers,
>
> Kris
>
>