This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa?] Implement ppc32 SYSV {extract,store} return value
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>, Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, Jason R Thorpe <thorpej at wasabisystems dot com>
- Date: Fri, 10 Oct 2003 14:00:47 -0700
- Subject: Re: [rfa?] Implement ppc32 SYSV {extract,store} return value
- References: <3F68D829.6010001@redhat.com> <1030922215845.ZM29725@localhost.localdomain> <3F7F06D8.9000702@redhat.com> <1031006191231.ZM12230@localhost.localdomain> <3F8714F5.2030605@redhat.com>
On Oct 10, 4:22pm, Andrew Cagney wrote:
> How is the attached?
Very close. I just noticed the following:
+ if ((TYPE_CODE (type) == TYPE_CODE_INT
+ && TYPE_LENGTH (type) == 8
+ && tdep->wordsize == 4)
+ || (TYPE_CODE (type) == TYPE_CODE_FLT
+ && TYPE_LENGTH (type) == 8 && tdep->wordsize == 4))
According to do_ppc_sysv_return_value's comment, tdep->wordsize will
have to be 4. (Since it's for the "SysV 32-bit PowerPC ABI...")
So, could you please do the following:
- Remove the ``tdep->wordsize == 4'' tests in the above expression.
- Insert the following statement at some appropriate place
at the beginning of the function:
gdb_assert (tdep->wordsize == 4);
Once that's done, it's okay. (Go ahead and check it in.)
Thanks,
Kevin