This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Breakpoint infrastructure cleanups [1/8] - define impl_breakpoint
- From: "Eli Zaretskii" <eliz at elta dot co dot il>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 08 Oct 2003 19:58:35 +0200
- Subject: Re: RFA: Breakpoint infrastructure cleanups [1/8] - define impl_breakpoint
- References: <20031008170233.GA9013@nevyn.them.org>
- Reply-to: Eli Zaretskii <eliz at elta dot co dot il>
> Date: Wed, 8 Oct 2003 13:02:33 -0400
> From: Daniel Jacobowitz <drow@mvista.com>
> +
> +enum impl_bptype
> +{
> + impl_bp_software_breakpoint,
> + impl_bp_hardware_breakpoint,
> + impl_bp_hardware_watchpoint,
> + impl_bp_other /* Miscellaneous... */
> +};
Why did you decide to leave the subclasses of hardware watchpoints
(read, access, and write) in the parent structure, instead of moving
that distinction here? That seems like you are spreading related
information between several places instead of having it in a single
place.