This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] add-symbol-file-from-memory command
- From: Roland McGrath <roland at redhat dot com>
- To: Jim Blandy <jimb at redhat dot com>
- Cc: Mark Kettenis <m dot kettenis at osp dot nl>,Kevin Buettner <kevinb at redhat dot com>,Daniel Jacobowitz <drow at mvista dot com>, Andreas Schwab <schwab at suse dot de>,Scott Bambrough <scottb at netwinder dot org>,gdb-patches at sources dot redhat dot com
- Date: Fri, 3 Oct 2003 15:08:22 -0700
- Subject: Re: [PATCH] add-symbol-file-from-memory command
> This is important thing to get right; I'm sorry it wasn't reviewed
> promptly back in May.
The apparent urgency it had then waned, so I stopped pushing on it and we
were all busy with other things. Only now is it really becoming important.
> It doesn't really belong in symfile.c. It's certainly Linux-specific
There is nothing Linux-specific about add-symbol-file-from-memory.
The implementation is ELF-specific, but the concept is not.
> The change itself looks fine. Reviewing it suggested various cleanups
> to symfile.c (say, symbol_file_add_with_addrs_or_offsets should always
> expect an opened BFD, and not take a name), but those are all
> independent of what you're trying to accomplish here, and needn't hold
> it up.
I am happy to do some cleanups while I'm in the area if it's clear what
ought to be done.