Re: [RFA] dwarf2-frame.c: Support DW_EH_PE_textrel encoding

[Mark Kettenis <kettenis at chello dot nl>]

   Date: Thu, 2 Oct 2003 22:06:52 +0200
   From: Corinna Vinschen <vinschen@redhat.com>

   Hi,

   I'm not sure if the patch is actually 100% correct but I think it's
   not far from that.

It looks sensible to me.

   For a few weeks now, gcc emits the DW_EH_PE_textrel encoding for sh
   and (AFAICS) ia64.  This encoding type is unsupported in gdb so far.
   The below patch tries to accomodate this encoding.

   Is the patch ok as it is?  On sh, the testcases failing with a gcc
   emitting this encoding run through with the below patch and the
   overall FAIL count is the same as before.

I've got a problem with re-using the variable named `got' in
dwarf2_build_frame_info() for the ".text" section.  Could you please
rename the variable to something more generic (for example `sect') or
introduce a new variable?

I'd also appreciate it if you changed gcc into GCC in the comment
(thats the spelling the GCC project uses, and makes the sentence start
with a capital).  You'll need to add an extra space after the . too.

With those changes, this is OK.

	   * dwarf2-frame.c (struct comp_unit): Add tbase member to store
	   base for DW_EH_PE_textrel encodings.
	   (read_encoded_value): Add a DW_EH_PE_textrel case.
	   (dwarf2_build_frame_info): Set unit.tbase to beginning of text
	   section.