This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Don't include value of expression in pc-fp.exp test name
- From: Jim Blandy <jimb at redhat dot com>
- To: Michael Elizabeth Chastain <mec at shout dot net>
- Cc: ac131313 at redhat dot com, carlton at kealia dot com, fnasser at redhat dot com,gdb-patches at sources dot redhat dot com
- Date: 30 Sep 2003 17:13:49 -0500
- Subject: Re: RFA: Don't include value of expression in pc-fp.exp test name
- References: <200309301749.h8UHnZkE029086@duracef.shout.net>
Michael Elizabeth Chastain <mec@shout.net> writes:
> Yeah! It makes my life easier!
>
> You need to add '2003' to the copyright year to the top of pc-fp.exp.
>
> Proofread. Tested on my test bed with 10 configurations.
> All the gdb.sum's come out identical now.
Fantastic. I think this deserves mention in NEWS.
2003-09-30 Jim Blandy <jimb@redhat.com>
* gdb.base/pc-fp.exp (get_valueofx): Don't include the value of
the expression in the pass message. This just creates spurious
differences in summary files.
Index: gdb/testsuite/gdb.base/pc-fp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1
diff -c -r1.1 pc-fp.exp
*** gdb/testsuite/gdb.base/pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1
--- gdb/testsuite/gdb.base/pc-fp.exp 30 Sep 2003 22:15:22 -0000
***************
*** 1,4 ****
! # Copyright 2002 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 2002, 2003 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
***************
*** 62,68 ****
gdb_expect {
-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
set val $expect_out(1,string)
! pass "get value of ${exp} ($val)"
}
timeout {
set size ${default}
--- 62,68 ----
gdb_expect {
-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
set val $expect_out(1,string)
! pass "get value of ${exp}"
}
timeout {
set size ${default}