This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] Fix ppc32 GNU/Linux (and AIX) struct convention
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Tue, 16 Sep 2003 13:19:52 -0700
- Subject: Re: [rfa] Fix ppc32 GNU/Linux (and AIX) struct convention
- References: <3F6392D5.30809@redhat.com>
On Sep 13, 5:57pm, Andrew Cagney wrote:
> * ppc-linux-tdep.c (ppc_linux_init_abi): Set the 32 bit
> "use_struct_convention" to "rs6000_use_struct_convention".
> * ppc-tdep.h (rs6000_use_struct_convention): Declare.
No. I would prefer that ppc-linux-tdep.c contain its own (suitably
named) "use_struct_convention" code even if it's identical to the code
needed by AIX. That way we can tweak one without having to worry
about breaking the other.
> * rs6000-tdep.c (rs6000_use_struct_convention): New function.
> (rs6000_gdbarch_init): For AIX, set "use_struct_convention" to
> "rs6000_use_struct_convention".
Okay.
> * ppc-sysv-tdep.c (ppc_sysv_abi_broken_use_struct_convention):
> Delete function.
> * ppc-tdep.h (ppc_sysv_abi_broken_use_struct_convention): Delete.
Okay.
Kevin