Re: [ob] frv/sim testsuite tweak

[Dave Brolley <brolley at redhat dot com>]

Michael Snyder wrote:

> Dave Brolley wrote:
>
> > Michael Snyder wrote:
> >
> > > Dave Brolley wrote:
> > >
> > > > Michael, please revert this change. This test uses several 
> > > > different notations to reference the lcr register and one of them 
> > > > is 'lcr'. As you can see spr[273] is tested a few lines later.
> > >
> > >
> > >
> > >
> > > Yeah, but 'lcr' had already been tested (twice) above.
> > > If I revert it, then the exact same line,
> > >     movgs    gr8, lcr
> > > is tested twice, while
> > >     movgs    gr8, spr[273]
> > > is not tested at all.
> >
> >
> >
> > OK. Now that I look at the entire test case, I see that this patch is 
> > correct.
>
>
> Of course, you could argue that we need to make sure that
> lcr is identical with spr[273].  Would you like me to add
> a third clause in which we store to lcr and retrieve from
> spr[273]?

Anything which makes a test case more robust is welcome.

Thanks,
Dave