This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Changes to allow extensions to operator set
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: Paul Hilfinger <hilfingr at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 05 Sep 2003 12:29:07 -0400
- Subject: Re: RFA: Changes to allow extensions to operator set
- References: <20030901093941.0D2E9F2A64@nile.gnat.com>
1. There was essentially duplicate code in prefixify_subexp and
length_of_subexp. I have factored out the duplication. [In the
process, by the way, I happened to notice that BINOP_VAL was
defined only in length_of_subexp, and indeed that there appears to
be no code anywhere to handle its evaluation.]
If I understand it correctly, this refactoring (hey I get to use a
buzword) making operator_length global and then calling it from
length_of_subexp is independant of the other stuff, so yes, it can go in.
Nice cleanup.
Andrew