This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Changes to allow extensions to operator set
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: Paul Hilfinger <hilfingr at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 05 Sep 2003 11:57:05 -0400
- Subject: Re: RFA: Changes to allow extensions to operator set
- References: <20030901093941.0D2E9F2A64@nile.gnat.com>
2. Currently, the function dump_prefix_expression is used to dump
postfix expressions and dump_postfix_expression is used to dump
prefix expressions. It is probably a sign of the weakening
effects of age on the intellect that I found this confusing, and
have renamed dump_prefix_expression to dump_raw_expression (because
in principle it doesn't really care whether the expression is
pre- or postfix), and dump_postfix_expression to dump_prefix_expression.
3. The current dump_prefix_expression tries to first print the expression
it is dumping with print_expression. This doesn't work, however,
because print_expression operates on prefix expressions, and
the current dump_prefix_expression is only used on postfix
expressions. I simply removed the print_expression.
Bang head against table. I think it's a sign that the code is rarely
exercised. Yes, ok.
Andrew