This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [REALLY NEW PATCH] Split sh and sh64
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 5 Sep 2003 11:43:59 -0400
- Subject: Re: [REALLY NEW PATCH] Split sh and sh64
- References: <20030818181602.GE3101@cygbert.vinschen.de><20030821131300.GA22323@cygbert.vinschen.de><20030829184734.GN7858@cygbert.vinschen.de>
Corinna Vinschen writes:
> Hi,
>
> I've attached the latest patch which eliminates a drawback of the first
> two patches. These patches created a new target sh64, which was
> entirely different from sh. So, if you'd build, say, sh64-elf, you would
> have gotten only sh5, nothing else. Building for sh would have given you
> sh up to sh4, but no sh5. The new and improved patch attached to this mail
> returns to only one build target sh-*-*, which allows to work with all
> sh CPUs from sh to sh5. Just the sh5 code is entirely moved to sh64-tdep.c
> for clearness. The other positive side effect is that the new subdirectory
> config/sh64 isn't needed.
>
> While I was at it, I found a problem with the `regs' user command.
> Switching between different architectures didn't work correctly. The
> function pointer has been set only when an architecture has been choosen
> for the first time. So I moved setting the sh_show_regs function pointer
> up to the beginning of sh*_gdbarch_init, to set it all the time when
> switching the architecture.
>
> ChangeLog:
> ==========
>
> * Makefile.in (ALLDEPFILES): Add sh64-tdep.c.
> (sh64-tdep.o): Add dependencies.
> * configure.tgt: Add FIXME to sh-*-linux*.
> * sh-tdep.c: Move sh64 support to sh64-tdep.c.
> (sh_gdbarch_init): Always set correct sh_show_regs function
> pointer. Call sh64_gdbarch_init() if machine type is sh5.
> * sh-tdep.h: Move sh64 support to sh64-tdep.c.
> * sh64-tdep.c: New file, containing all sh64 related code from
> sh-tdep.c.
> * config/sh/embed.mt (TDEPFILES): Add sh64-tdep.o.
> * config/sh/linux.mt (TDEPFILES): Ditto.
> * config/sh/nbsd.mt (TDEPFILES): Ditto.
> * config/sh/tm-sh.h: Drop REGISTER_TYPE definition.
> * config/sh/wince.mt (TDEPFILES): Ditto.
>
OK.
elena