This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH/RFA] Sync window sizes between Readline and GDB
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sun, 17 Aug 2003 16:35:04 -0400
- Subject: Re: [PATCH/RFA] Sync window sizes between Readline and GDB
- References: <200308171841.h7HIfDdl034523@elgar.kettenis.dyndns.org>
On Sun, Aug 17, 2003 at 08:41:13PM +0200, Mark Kettenis wrote:
> Folks,
>
> The attached makes sure GDB's and Readline's idea of the screen size
> are the same. It gets rid of some rather platform-specific code and
> uses similar code in Readline instead. This fixes the problems I was
> seeing in completion.exp.
>
> I don't think we should check this in on the branch, since there is a
> certain risk involved that things break for certain hosts. However, I
> think making use of the code in Readline is a good thing since that
> code is defenitely better tested than our code.
>
> OK for mainline?
This certainly looks like a good idea to me. I tried it on a GNU/Linux
system that was showing similar problems, and it fixed those as well.
It introduces new warnings in utils.c though. There's one call to
set_width above its declaration and you removed the prototype.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer