Re: [dictionary] commit for 2003-03-06

[David Carlton <carlton at math dot stanford dot edu>]

On 07 Mar 2003 08:53:00 -0800, David Carlton <carlton at math dot stanford dot edu> said:

> And there might be uses elsewhere, too: I haven't yet audited all the
> uses of lookup_minimal_symbol.  I'm fairly sure that the symbol lookup
> functions in symtab.c are safe, from memory, and there shouldn't be
> _too_ many other places that want a natural name when looking at
> minimal symbols, but there might be some.

In fact, there are: the .y files all have likely candidates, and I
want to look more closely at a handful of other uses (in remote.c,
printcmd.c, objc-lang.c, and valops.c).  So the demangled hash table
definitely stays.

Which raises another interesting issue: should whatever of those uses
turn out to want natural names also accept linkage names?  I'm
reluctantly starting to think that they should.  They typically call
lookup_minimal_symbol with a string taken from user input; in an ideal
world, I think it would be reasonable to not allow users to get at
stuff via linkage names, but there have been enough C++ bugs that can
be worked around if you know the linkage name that I don't think we're
there yet.  Hmm; I'll have to think about what internal interface I
like, given that desire.

David Carlton
carlton at math dot stanford dot edu