This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Prologue detection on x86-64
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: GDB Patches <gdb-patches at sources dot redhat dot com>
- Date: Thu, 6 Mar 2003 18:10:08 -0500
- Subject: Re: [RFA] Prologue detection on x86-64
- References: <3E67D22C.3030908@suse.cz>
On Thu, Mar 06, 2003 at 11:56:44PM +0100, Michal Ludvig wrote:
> Hi all,
> the attached patch moves prologue detection from x86_64_skip_prologue()
> to separate function, that could be reused later. I need this separate
> function to implement unwinding of functions without debug info.
>
> It's an almost obvious patch, I believe.
>
> OK to commit?
Just two things:
> +/* We will handle only functions beginning with:
> + 55 pushq %rbp
> + 48 89 e5 movq %rsp,%rbp */
Period and two spaces, please.
> +#define PROLOG_BUFSIZE 4
> +static int
> +x86_64_function_has_prologue (CORE_ADDR pc)
> +int x86_64_function_has_prologue (CORE_ADDR pc);
That's probably a warning. Static functions don't need to be
prototyped in the tdep.h file; this bit can just be omitted.
Other than that OK.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer