This is the mail archive of the
mailing list for the GDB project.
Re: [RFA] (ping) GDB crash when using command lines due to memory corruption
- From: Joel Brobecker <brobecker at gnat dot com>
- To: Klee Dienes <klee at apple dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 13 Jan 2003 07:21:11 +0400
- Subject: Re: [RFA] (ping) GDB crash when using command lines due to memory corruption
- References: <20021211173805.GG25575@gnat.com> <8096FEF2-0D32-11D7-9BDD-00039396EEB8@apple.com>
There is a patch that was submitted on Oct 30th 2002 but hasn't been
reviewed because it addresses a GDB crash. It also expands break.exp
to test for this.
Can somebody have a look please?
Klee, I'll be happy to check it in for you if you lack the time.
On Wed, Dec 11, 2002 at 01:00:58PM -0500, Klee Dienes wrote:
> A safer change for 5.3 might be the patch I submitted on October 30th.
> Rather than deal with sharing the command-line structure, I just
> updated bpstat_copy to match its comment, and do a deep copy of the
> command lines as well as the value. I don't really have a strong
> opinion about copying the command lines vs. managing them the way Joel
> proposes, although my patch does have the argument of simplicity going
> for it. On the other hand, if/when we go to a more sophistiated
> command-line evaluator, we'll probably want the command body to be some
> opaque and externally managed structure anyway.
> Whichever patch we end up taking, though, we should be sure to update
> the comment in bpstat_copy and add my proposed change to the test suite.