This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: coffread.c extension for DLLs without debugging symbols
"Eli Zaretskii" <eliz@is.elta.co.il> wrote in message
2110-Sat04Jan2003130101+0200-eliz@is.elta.co.il">news:2110-Sat04Jan2003130101+0200-eliz@is.elta.co.il...
> > From: "Raoul Gough" <RaoulGough@yahoo.co.uk>
> > Date: Fri, 3 Jan 2003 19:39:31 -0000
> >
> > This is my *first* gdb patch submission,
> > so someone with more experience should probably take a good look
at
> > (e.g. is coffread.c the right place for this kind of code?).
>
> Lesson number 1: post the diffs as plain text, not uuencoded or
> otherwise encoded. Some people, such as myself, don't have time to
> open binary attachments, but do have time to read a patch that's in
> plain text.
OK, point taken. I was assuming that it was better to reduce some
bandwidth, given the size of the patch (circa 10kB). OK, you can all
laugh at me now for being so bandwidth-challenged that I still think
about that stuff :-)
>
> Also, please include "[RFA]" in the subject, so that we know you are
> seeking an approval for your patch.
What does RFA stand for? Seemed to me like it was used by people who
were actually capable of updating the CVS themselves and just wanted
confirmation.
>
> > Proposed ChangeLog entry, assuming the code is accepted:
> >
> > 2003-01-03 Raoul Gough <RaoulGough@yahoo.co.uk>
> >
> > * coffread.c: Support non-debug export symbols for win32 DLLs
>
> This should mention every function where changes are made,
preferably
> with a description of a change in each one of them.
Done! See my reply to Christopher Faylor on the patches mailing list.
>
> And thanks for working on this.
No problem - hope it's useful to some people.
Regards,
Raoul Gough.