This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] arm_store_return_value, big-endian
- From: Michael Snyder <msnyder at redhat dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>, gdb-patches at sources dot redhat dot com, cagney at redhat dot com, kevinb at redhat dot com, rearnsha at arm dot com
- Date: Wed, 06 Nov 2002 16:14:41 -0800
- Subject: Re: [RFA] arm_store_return_value, big-endian
- Organization: Red Hat, Inc.
- References: <3DC9AA92.5FA9D709@redhat.com> <3DC9ACB3.6070605@redhat.com> <3DC9AF8E.667002A4@redhat.com>
Michael Snyder wrote:
>
> Andrew Cagney wrote:
> >
> > > This corresponds to the earlier patch for arm_extract_return_value.
> > >
> > >
> > >
> > > 2002-11-06 Michael Snyder <msnyder@redhat.com>
> > >
> > > * arm-tdep.c (arm_store_return_value): Handle offset of
> > > small types on big-endian machines.
> > >
> > > Index: arm-tdep.c
> > > ===================================================================
> > > RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> > > retrieving revision 1.74
> > > diff -p -r1.74 arm-tdep.c
> > > *** arm-tdep.c 1 Nov 2002 21:21:49 -0000 1.74
> > > --- arm-tdep.c 6 Nov 2002 23:47:34 -0000
> > > *************** gdb_print_insn_arm (bfd_vma memaddr, dis
> > > *** 2151,2156 ****
> > > --- 2151,2159 ----
> > > memaddr = UNMAKE_THUMB_ADDR (memaddr);
> > > info->symbols = &asym;
> > > }
> > > + else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
> > > + write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
> > > + valbuf, TYPE_LENGTH (type));
> > > else
> > > info->symbols = NULL;
> > >
> >
> > Write register bytes is dead.
>
> I'm not having this argument with you again, Andrew.
> If you want the fix, take it. If not, don't.
Hang on -- that diff is entirely wrong. My use of write_register_bytes
was supposed to be replacing an existing use of write_register_bytes.
Let me see what went wrong...