This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] add selected-frame-level-changed events


+   /* NOTE: kseitz/2002-08-28: It would be nice to call
``FIXME''. The call can't be here due to limitations in the current implementation :-)

+ selected_frame_level_changed_event right here, but we would end up
+ flooding the UI with events because select_frame is used extensively
+ internally. Instead, event notifications are scattered through
+ the "UI" code, select_frame_command, up_silently_base, and
+ down_silently_base. */

Suggest adding something like.

``Once everything is parameterized with a frame, the hook can be moved here since at that point, this function will be called when the users selected frame is being changed.''.

So that the change has an ``exit clause''. that way it is clear when the fixme can be deleted/fixed.

Otherwize, yes, just commit
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]