This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Minor reformatting in infrun.c


Joel Brobecker wrote:
> 
> > > I can commit the following patch. I verified that a later re-indent
> > > does not cause a formatting change in the second argument.
> >
> > Yes,
> 
> I committed this change.
> 
> > and now I can see no reason not to put the arguments back
> > the way they were originally.  Or, say.
> >
> >   stop_bpstat =
> >     bpstat_stop_status (&stop_pc,
> >                         [...]
> 
> Absolutely. But unfortunately this is not the way indent formats it:
> 
> <<
>           stop_bpstat =
>             bpstat_stop_status
>             (&stop_pc,
>              sw_single_step_trap_p
>              || (currently_stepping (ecs)
>                  && prev_pc != stop_pc - DECR_PC_AFTER_BREAK
>                  && !(step_range_end
>                       && INNER_THAN (read_sp (), (step_sp - 16)))));
> >>
> 
> Should I check-in the indent'ed version anyway? (I would send a separate
> [PATCH] message)

Nah, I guess we've wasted enough cycles worrying about this 
rather trivial change.  ;-)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]