This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] 64-bit support for Irix 6


Andrew Cagney wrote:
> 
> >
> >  #include "mips/tm-bigmips.h"
> >
> > +#undef MIPS_REGSIZE
> > +#define MIPS_REGSIZE 8
> > +
> >  /* SGI's assembler doesn't grok dollar signs in identifiers.
> >     So we use dots instead.  This item must be coordinated with G++. */
> >  #undef CPLUS_MARKER
> > @@ -89,11 +92,12 @@
> >        32 * sizeof(double) + ((N) - 32) * MIPS_REGSIZE)
> >
> >  #undef  REGISTER_VIRTUAL_TYPE
> > +/* define 8 byte register type */
> >  #define REGISTER_VIRTUAL_TYPE(N) \
> >       (((N) >= FP0_REGNUM && (N) < FP0_REGNUM+32) ? builtin_type_double \
> >        : ((N) == 32 /*SR*/) ? builtin_type_uint32 \
> >        : ((N) >= 70 && (N) <= 89) ? builtin_type_uint32 \
> > -      : builtin_type_int)
> > +      : builtin_type_long_long)
> >
> >  /* Force N32 ABI as the default. */
> >  #define MIPS_DEFAULT_ABI MIPS_ABI_N32
> >
> 
> Kevin, this is wrong.
> 
> It is no longer acceptable to add support for an additional sub-target
> using non-multi-arch mechanisms.

Does that mean that if we touch a macro, we have to multi-arch it?
For instance, if we touch the PUSH_ARGUMENTS function, and
PUSH_ARGUMENTS 
hasn't been multi-arched, do we have to multi-arch it?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]