This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA]: Adapt solib-svr4.c for recent gdbarch_data changes


Discovered this moring that my gdb was crashing.  Seems like we have
an initialization cycle here.  I think that after Andrew's patch we
can simplify init_fetch_link_map_offsets as in the attached patch.
Oops! The target I tried this on sets the link map offset.
(So this also means that the cycle test works?)

OK to check this in?

	* solib-svr4.c (init_fetch_link_map_offsets): Simply return
	legacy_fetch_link_map_offsets.  Adjust comment to reflect reality
	after Andrew's 2002-06-08 gdbarch change.
I think it might have to go under an ``obvious fix''. I definitly broke the code and the way you've changed things is the only way to do it.

I think I'll update the [about to commit] doco to reflect this.

Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]