Re: [patch/rfc] Delete sim/z8k/list.c

[Christian Groessler <chris at groessler dot org>]

On Sun, 2 Jun 2002, Andrew Cagney wrote:

> Following up the change:
>
> > 2002-05-07  Christian Groessler <chris@groessler.org>
> >> >
> >> >         * list.c: Regenerated with current opcodes/z8k-opc.h.
> >
> >>
> >> How do I do this?  I was thinking that the patch was too big but, if the
> >> bulk is generated then yes, it is ok.
> >
> >
> > It is generated. Edit sim/z8k/writecode.c and set the DIRTY_HACK
> > define to 1. I think it's not really needed anymore, but the old
> > list.c was generated with the same define.
> >
> > Then compile writecode.c (it will also be compiled if you build gdb
> > for z8k-coff) and do a "./writecode -m > list.c".
>
> The attached patch deletes sim/z8k/list.c instead [re]generating its
> contents each time writecode is run.  While it might make building the
> z8k simulator slower, I think it makes its maintenance much easier - one
> less generated file to contend with.

I agree.

> If no one sees problems, I'll commit it in a few days.  The files
> generated by writecode appear to be identical with/without the change
> (but only if the before case has a freshly re-generated list.c, er, hmm
> .... :-).

What do you mean by that? The old list.c was definately wrong (since
z8k-opc.h was changed).

I tried your patch, and it works for me. Please commit.

regards,
chris