This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] PPC ABI compliance fix


Andrew Cagney writes:
 > > Index: ppc-linux-tdep.c
 > > ===================================================================
 > > RCS file: /cvs/uberbaum/gdb/ppc-linux-tdep.c,v
 > > retrieving revision 1.13
 > > diff -u -r1.13 ppc-linux-tdep.c
 > > --- ppc-linux-tdep.c	2002/02/24 22:31:19	1.13
 > > +++ ppc-linux-tdep.c	2002/03/22 18:48:39
 > > @@ -414,6 +414,14 @@
 > >     it may be used generically by ports which use either the SysV ABI or
 > >     the EABI */
 > >  
 > > +/* Structures 8 bytes or less long are returned in the r3 & r4
 > > +   registers, according to the SYSV ABI. */
 > > +int
 > > +ppc_sysv_abi_use_struct_convention (int gcc_p, struct type *value_type)
 > > +{
 > > +  return (TYPE_LENGTH (value_type) > 8);
 > > +}
 > > +
 > >  /* round2 rounds x up to the nearest multiple of s assuming that s is a
 > >     power of 2 */
 > 
 > Should this live in rs6000-tdep.c?

Yes, There is a FIXME about that in the file. I am not sure why
sysv_push_arguments is in that file as well. I didn't want to change
it in case there was some real technical problem.

Maybe Kevin knows why?

Elena


 > 
 > enjoy,
 > Andrew
 > 
 > 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]