This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] remote debugging patches
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: Michal Ludvig <mludvig at suse dot cz>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 10 Mar 2002 15:15:56 -0500
- Subject: Re: [RFA] remote debugging patches
- References: <3C8BA71F.20807@suse.cz>
Michal, as an aside, these are independant changes, it is really helpful
if they are submitted separatly (making review much easier).
* remote.c: Added WAIT_FOREVER_FLAG and changed all
calls to getpkt() to respect it.
> +#define WAIT_FOREVER_FLAG 0
Yes fine, er almost. Can you change the name of this to
``DONT_WAIT_FOREVER_FLAG'' and suggest making it an enum. (so GDB can
print it :-)
If you're feeling really inspired (...), you could even introduce an
enum to handle both the DO and DONT cases.
Andrew