This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] x86-64 target bugfixes 3
- From: Andreas Jaeger <aj at suse dot de>
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Cc: Jiri Smid <smid at suse dot cz>, gdb-patches at sources dot redhat dot com,Michal Ludvig <mludvig at suse dot cz>
- Date: Sun, 20 Jan 2002 10:28:46 +0100
- Subject: Re: [RFA] x86-64 target bugfixes 3
- References: <s8vadweb6tt.fsf@naga.suse.cz> <3C49B218.7020900@cygnus.com>
Andrew Cagney <ac131313@cygnus.com> writes:
>> Index: ChangeLog
>> from Jiri Smid <smid@suse.cz>
>> * x86-64linux.mh (NATDEPFILES): x86-64-nat.o removed.
>> * x86-64-linux-nat.c (x86_64_register_u_addr): New function.
>> * nm-x86-64.h (ATTACH_LWP): Removed.
>> * Makefile.in (x86-64-tdep.o, x86-64-linux-tdep.o,
>> x86-64-linux-nat.o): Fix dependencies.
>> * xm-i386.h (solib.h): Include.
>>
>
>
> Jiri, I suspect several people looked around and then assumed another
> person was handling this change :-( Sorry.
>
> One cosmetic tweek for the ChangeLog. x86-64linux.mh et.al. should
> read config/i386/x86-64linux.mh et.al. - the full path to files in sub
> directories is needed.
>
> Everything is fine except the tweek to xm-i386.h. The xm file is for
> host configury, not native configury. I suspect you ment to add it to
> config/i386/nm-<something>.h.
I left this patch out, since nm-x86-64.h contains those lines already.
I committed the rest and adjusted the copyright year also,
Andrew, Thanks for the review,
Andreas
* config/i386/x86-64linux.mh (NATDEPFILES): x86-64-nat.o removed.
* x86-64-linux-nat.c (x86_64_register_u_addr): New function.
* config/i386/nm-x86-64.h (ATTACH_LWP): Removed.
* Makefile.in (x86-64-tdep.o, x86-64-linux-tdep.o,
x86-64-linux-nat.o): Fix dependencies.
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj