This is the mail archive of the
mailing list for the GDB project.
Re: [RFA]: testsuite/gdb.base/a2-bin.exp: Consider `needs_status_wrapper' target_info
On Wed, Dec 05, 2001 at 09:17:08PM +0100, Corinna Vinschen wrote:
> On Wed, Dec 05, 2001 at 02:54:40PM -0500, Daniel Jacobowitz wrote:
> > On Wed, Dec 05, 2001 at 08:25:07PM +0100, Corinna Vinschen wrote:
> > > 2001-12-05 Corinna Vinschen <email@example.com>
> > >
> > > * gdb.base/a2-bin.exp: Pass first test even if the return
> > > code is 0 if target_info `needs_status_wrapper' exists.
> > Please don't turn this into a PASS; it didn't really test anything as I
> > read it. "unsupported" is probably the appropriate return code.
> I don't think so. The test tests that the application returns
> it's usage so it has tested that the application got it's argc
> correctly. That's what the test is for, right? It's just an
> _additional_ test that the return code is 1. It's not GDB's
> fault that the target can't return the return code correctly.
[BTW, it's a2-run.exp]
OK, I misread. You might want to break this up into two tests;
you can just replace the one pass by two passes, and the pass you were
adding by a pass and an unsupported. May not be worth the effort.
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer