This is the mail archive of the
mailing list for the GDB project.
Re: [rfa/i386] Throw i386's multi-arch switch
- To: Andrew Cagney <ac131313 at cygnus dot com>
- Subject: Re: [rfa/i386] Throw i386's multi-arch switch
- From: Mark Kettenis <kettenis at science dot uva dot nl>
- Date: 08 Nov 2001 18:36:31 +0100
- Cc: gdb-patches at sources dot redhat dot com
- References: <3BE9ED9F.firstname.lastname@example.org>
Andrew Cagney <email@example.com> writes:
> The attached tweeks the i386 targets (all of them) so that they are
> built with multi-arch enabled. While this is far from having the i386
> properly multi-arched it does get the target over one of the major
> multi-arch conversion hurdles.
The string of multi-arch patches made me suspect you were trying to do
> The change does contain one hack - i386-tdep.h had all its macros
> wrapped in #ifndef conditionals. This is so that the old targets
> continue to work.
Ouch, that's ugly. However, I suspect that i386-tdep.h needs some
serious polishing anyway, so go ahead.
> I've tested it on both Red Hat GNU/Linux 7.2 (no change) and FreeBSD
> 3.5.1 (tickles a GCC bug).
> ok to commit?
Just one question: do we really want that XMALLOC macro? In this case
I'd simply use an explicit cast. Otherwise: Yes please.