This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] mdebugread.c: remove use of partial-stab.h
- To: gdb-patches at sources dot redhat dot com
- Subject: Re: [PATCH] mdebugread.c: remove use of partial-stab.h
- From: Elena Zannoni <ezannoni at cygnus dot com>
- Date: Tue, 06 Nov 2001 16:55:56 -0500
- References: <3BE85C2A.36572D80@cygnus.com>
Elena Zannoni wrote:
> This is removing the second occurrence of the infimous
> #include "partial-stab.h" from gdb.
> This time the file is mdebugread.c. Including the code directly
> allowed to get rid of code that was ifdeffed DBXREAD_ONLY. Almost all
> of all the SOFUN_ADDRESS_MAYBE_MISSING instances were under
> DBXREAD_ONLY as well, except 2. So those are left for a second pass.
> I am not yet sure we can get rid of them. I also suspect that the
> giant switch can be further simplified a bit.
> Next step is to get rid of the last include "partial-stab.h" which is
> in dbxread.c.
> As usual I'll wait a day or so before I commit this, in case somebody
> wants to take a look at it.
> Jim (Blandy), I would be extremely grateful if you could wait until
> this in in before going ahead with another patch for the address sets.
> I tested this on Irix 6.3.
> 2001-10-25 Elena Zannoni <firstname.lastname@example.org>
> * mdebugread.c (CUR_SYMBOL_TYPE, CUR_SYMBOL_VALUE,
> END_PSYMTAB, SET_NAMESTRING, HANDLE_RBRAC): Delete definitions.
> (parse_partial_symbols): Don't include partial-stab.h any
> more. Don't reuse code in partial-stab.h, include the code
> directly, instead. Simplify code from partial-stab.h eliminating
> ifdef DBXREAD_ONLY code.
> * Makefile.in (mdebugread.o): Remove dependency on