This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

configure.tgt; Was: [RFA]: x86_64 target files


> 	* configure.tgt: Likewise.


Again, could I suggest mentioning the x86_64->i386 cpu map.

As with the host, the target files need to be broken along OS vs generic 
architecture lines.


>   # OBSOLETE w65-*-*)		gdb_target=w65 ;;
> + 
> + x86_64-*-linux*)	gdb_target=x86_64
> +  		configdirs="${configdirs} gdbserver" ;;


Could this please be changed to:

	x86_64-*-linux*)	gdb_target=<something-linuxish>
		configdirs=... ;;
	x86_64-*-*)	gdb_target=x86_64 ;;

i.e. again, separate out the linux specific stuff from the more generic 
x86_64 stuff.

Further down in that same file is the code to mark this target as 
multi-arch.  I think that should apply to x86_64-*-*.  This would mean 
that tm-x86_64 is redundant.


> 	* config/i386/x86_64.mt: New file.


Per the above, I think there should be two files:

	x86_64.mt
		which would not contain GDBSERVER_*
	<something linuxish>.mt
		which contains GDBSERVER_*


> 	* config/i386/tm-x86_64.h: New file.


Per the above, this file can probably be eliminated.

	Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]