Re: [RFA] The MIPS/Linux port

[Daniel Jacobowitz <dmj+ at andrew dot cmu dot edu>]

On Wed, Jul 04, 2001 at 11:51:27PM +0200, Mark Kettenis wrote:
> Looks like the MIPS port was started before a bit of reformatting of
> the sources and conversion to ISO C took place.  Please
> 
>  * Format the copyright notice at the beginning of the file as all
>    (most of) the other files, for example i386-linux-tdep.c.
> 
>  * Don't put a start on every line of multi-line comments.
> 
>  * Put two spaces after a full stop (.) in comments, even at the end
>    of the comment.  Make the comments full senteces, including a full
>    stop at the end of them.
> 
>  * Wrap long comments.
> 
>  * Use ISO C prototypes and function definitions, e.g.
>    
>       int
>       get_longjmp_target (CORE_ADDR *pc)
>       {
> 
>    and
> 
>       static void fetch_core_registers (char *, unsigned, int, CORE_ADDR);
> 
>    (get rid of PARAMS).

Thanks.  I'll do these and repost it.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer