This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: do_captured_thread_select
- To: Eirik Fuller <eirik at netapp dot com>
- Subject: Re: do_captured_thread_select
- From: Michael Snyder <msnyder at cygnus dot com>
- Date: Mon, 09 Apr 2001 11:20:58 -0700
- CC: gdb-patches at sourceware dot cygnus dot com
- Organization: Red Hat
- References: <39C17C60.3125D2C0@netapp.com> <39C18CBC.1BC1F728@netapp.com> <39D17683.FB3CA962@netapp.com> <3A113B77.B50A60D7@cygnus.com> <3A11D01C.7F0ADFCC@netapp.com> <3A11FA7A.CCC941C3@cygnus.com> <3A12022E.D96AB1EA@netapp.com> <3A15C2E7.6EC92753@netapp.com> <3AD17CE3.AA280B97@netapp.com>
Eirik Fuller wrote:
>
> This patch allows gdb's thread command to be used in macros. I've been
> using it since mid November with no problems (and I apologize for the
> delay in submitting it).
>
> --- gdb/thread.c- Wed Feb 2 20:14:36 2000
> +++ gdb/thread.c Thu Nov 16 20:31:42 2000
> @@ -663,7 +670,7 @@
> int num;
> struct thread_info *tp;
>
> - num = atoi ((char *)tidstr);
> + num = value_as_long(parse_and_eval(tidstr));
>
> tp = find_thread_id (num);
Can you explain the significance of change? Sorry if I'm being slow,
but I don't see it. What's the problem that you're fixing?
Also (not to be pedantic), we generally appreciate a ChangeLog entry
to accompany a patch.
Thanks,
Michael Snyder