This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Fix xasprintf() usage in solib-aix5.c
- To: Kevin Buettner <kevinb at cygnus dot com>
- Subject: Re: [PATCH] Fix xasprintf() usage in solib-aix5.c
- From: Mark Kettenis <kettenis at science dot uva dot nl>
- Date: 27 Mar 2001 11:46:16 +0200
- Cc: gdb-patches at sources dot redhat dot com
- References: <1010327062855.ZM2972@ocotillo.lan>
Kevin Buettner <kevinb@cygnus.com> writes:
> I've just committed the change below.
>
> * solib-aix5.c (build_so_lib_from_mapfile): Fix xasprintf() usage.
>
> Index: solib-aix5.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/solib-aix5.c,v
> retrieving revision 1.7
> diff -u -p -r1.7 solib-aix5.c
> --- solib-aix5.c 2001/03/16 18:06:44 1.7
> +++ solib-aix5.c 2001/03/27 06:18:58
> @@ -193,13 +193,14 @@ build_so_list_from_mapfile (int pid, lon
>
> {
> int mapbuf_allocation_size = 8192;
> - char map_pathname[64];
> + char *map_pathname;
> int map_fd;
>
> /* Open the map file */
>
> - xasprintf (map_pathname, "/proc/%d/map", pid);
> + xasprintf (&map_pathname, "/proc/%d/map", pid);
> map_fd = open (map_pathname, O_RDONLY);
> + free (map_pathname);
Shouldn't that be xfree()?
> if (map_fd < 0)
> return 0;
>