This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFA] procfs.c related changes for AIX 5
- To: gdb-patches at sourceware dot cygnus dot com
- Subject: Re: [PATCH RFA] procfs.c related changes for AIX 5
- From: Michael Snyder <msnyder at cygnus dot com>
- Date: Tue, 13 Mar 2001 17:24:49 -0800
- Cc: kevinb at redhat dot com
- Newsgroups: cygnus.patches.gdb
- Organization: Red Hat
- References: <1010306025828.ZM8793@ocotillo.lan>
Kevin Buettner wrote:
>
> The patch below represent the changes needed to procfs.c and related files
> for making GDB work natively on AIX5/IA-64.
Kevin,
This patch looks fine. I just have a few requests:
* struct sigaction and struct siginfo: could you use a typedef
instead of a define? It will make debugging easier.
* SYSENT_PROC_NAME_FMT: there is a changelog entry without a referent.
* HAVE_SYS_SYSCALL_H, HAVE_SYS_FAULT_H: I didn't see any configury
changes that would define these. Also, I think your changelog
entries ought to say "include conditionally", rather than just
"include". These headers were already being included.
That's it, I think. Nice piece of work! ;-)
Oh -- your port doesn't use SYS_lwp_create etc?
Does that mean there are no threads?