This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA]: Remove unused header files.


"J.T. Conklin" wrote:
> 
> >>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
> >> The decode_line_1() declaration (IMO) indicates a unclear separation
> >> of interface and implementation.  (Again, IMO) a function declaration
> >> should only be in one header.  Please share your thoughts, on this
> >> specific case, and in general.  decode_line_1() is the first of many
> >> functions that have multiple declarations.
> 
> Andrew> Only one? Just don't get me started on the number of extern
> Andrew> declarations that appear in .c files! :-) Yes, I agree that
> Andrew> function declarations should only appear once.
> 
> Is this one of the things your static analysis database is checks for
> (And can you send me a pointer to it again)?

Static analysis database? You mean that big nasty (probably broken) awk
script?

http://sources.redhat.com/gdb/ari/

It checks it but doesn't list it (well not by default).

	Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]