This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA]: Remove unused header files.



> The decode_line_1() declaration (IMO) indicates a unclear separation
> of interface and implementation.  (Again, IMO) a function declaration
> should only be in one header.  Please share your thoughts, on this
> specific case, and in general.  decode_line_1() is the first of many
> functions that have multiple declarations.

Only one? Just don't get me started on the number of extern declarations
that appear in .c files! :-)  Yes, I agree that function declarations
should only appear once.

As for the more general question of confused interfaces.  I think GDB's
internal structure is facing major change (multi-arch).  Consequently
I'm hopeing that that that that work will address many of those
problems.  I suspect that, at this stage, you might want to put blinkers
and just concentrate on the basic #include mess.  That, by its self, is
pretty daunting.

Good luck!
	Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]