This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFA: Patch to add "auto-evaluate" variables to varobj package.


James Ingham wrote:
> What do you think?

Don't forget that there isn't any need to use PARAMS and K&R in new code
:-)

> *************** varobj_list (struct varobj ***varlist)
> *** 845,850 ****
> --- 863,872 ----
>      expression to see if it's changed.  Then go all the way
>      through its children, reconstructing them and noting if they've
>      changed.
> +    Return value:
> +     -1 if there was an error updating the varobj
> +     -2 if the type changed
> +     Otherwise it is the number of children + parent changed
> 
>      Only root variables can be updated... */

This is beginning to sound like something that desperately needs an
interface cleanup.
Perhaps the nr of children as an argument and an enum for the return
value.

And wow!  Going through the MI tests must have been a real ordeal!

	enjoy,
		Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]