This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Split linespec from symtab
- To: Elena Zannoni <ezannoni at cygnus dot com>
- Subject: Re: RFA: Split linespec from symtab
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Fri, 10 Nov 2000 14:57:58 -0500
- CC: gdb-patches at sources dot redhat dot com, Andrew Cagney <cagney at cygnus dot com>
- Organization: Red Hat , Inc. - Toronto
- References: <3A0C1B21.A3FAD4D5@cygnus.com> <14860.18413.152072.687866@kwikemart.cygnus.com>
Elena Zannoni wrote:
>
> Fernando, this is OK with me.
> 2 things though:
>
> 1. Who's going to maintain this file?
> I am asking because there are some patches pending from Dan, and I
> don't want those to fall through the cracks. Maybe I can be a
> co-maintainer?
>
I believe this is an interface between GDB's symbolic services and the
interpreters (both command line and GUI) which use it.
If Andrew does not object, I believe the maintainers of symtab.c (Jim and Elena)
should be responsible for this file with perhaps the addition of myself as a
CLI/GUI representative.
> 2. Some C++ specific functions will be moved to linespec.c to which they
> don't really belong, just as they didn't belong to symtab.c.
> So at some stage the c++ functions may be further separated, into
> their own files. But this is not a problem, I would think. Maybe
> add a comment to that effect in linespec.c.
>
Good move. I had noticed that and I agree with it (I even mentioned one of these
functions in my submission).
But I rather add the comments afterwards so this patch shows just the
unchanged movement of code, for documentation purposes.
We add the FIXMEs in a separate commit. Is that OK?
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9