This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: gdb under solaris7
- To: Nick Duffek <nsd at redhat dot com>
- Subject: Re: gdb under solaris7
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Fri, 10 Nov 2000 17:47:27 +1100
- Cc: and at genesyslab dot com, gdb-patches at sourceware dot cygnus dot com, cagney at redhat dot com
- References: <Pine.GSO.4.10.10008301709250.1810-200000@muppet> <200011071955.eA7JtFk28809@rtl.cygnus.com>
Nick Duffek wrote:
> remote.c:
> >! scan = (char *) ref;
> [...]
> >! scan = (unsigned char *) ref;
>
> Looks right.
? :-)
Hmm, many of the remote.c changes look wierd :-). Simply type casting
something to avoid a warning tend to hide a more serious underlying
problem. For instance:
> remote.c:
> >! pkt = unpack_int (pkt, &tag); /* tag */
> [...]
> >! pkt = unpack_int (pkt, (int *)&tag); /* tag */
>
> How about declaring tag as an int instead? Better not to use typecasts
> when easily avoidable, I think. Andrew?
TAG should have the correct type for the reference parameter. The cast
shouldn't be needed.
Could I suggest going back through and re-thinking any changes that
involve casts.
enjoy,
Andrew