Re: [PATCH RFC] Protoize m32r-stub.c, m88k-nat.c, m88k-tdep.c

[Andrew Cagney <ac131313 at cygnus dot com>]

Kevin Buettner wrote:
> 
> On Sep 15, 10:50am, J.T. Conklin wrote:
> 
> > >>>>> "Kevin" == Kevin Buettner <kevinb@cygnus.com> writes:
> > Kevin> I did three files this time because there was only one function that
> > Kevin> needed doing in each of them.  (The m88k-*.c files bring back old
> > Kevin> memories; I first started hacking on gdb on an m88k box in the early
> > Kevin> nineties.)
> > Kevin>
> > Kevin>        * m32r-stub.c (prepare_to_step): Protoize.
> >
> > Should we consider not protoizing the *-stub.c files?  While these are
> > distributed with GDB, they are code that is going to be hacked to bits
> > as they are integrated into a remote target.  While user is probably
> > using gcc, it may be reasonable to be as conservative we can when it
> > comes to these files...
> 
> You're right.  I think that Andrew (and perhaps others) warned me about
> this too.

I don't remember.

I do remember raising a flag with respect to some of the subdirectories,
such as the RDI code.  In those cases, GDB, isn't the master repository
so we should avoid large scale changes.

For the stubs, however, GDB is the master repository so we're free to
(within reason) do as we wish.  As for what to do, I don't have an
opinion.

	Andrew