Re: nrun.c patch

[Stephane Carrez <Stephane dot Carrez at worldnet dot fr>]

Hi!

Doug Evans a écrit :
> 
> I _really_ don't like this patch and would like it reverted.
> 
> Thu Jul 27 20:37:47 2000  Andrew Cagney  <cagney@b1.cygnus.com>
> 
>         From 2000-06-25 Stephane Carrez <Stephane.Carrez@worldnet.fr>:
>         * nrun.c (main): Print the simulator statistics only in
>         verbose mode.
> 
> I use to be able to say
> 
> "m32r-run -p foo" and get some useful output.
> 
> Now I have to say
> 
> "m32r-run -p -v foo"
> 
> The patch makes the user have to say
> -p: "I'd like various profiling statistics collected please",
> -v: "Oh, and by the way, I'd also like you to print them out.
>      Yes, I know there's no real point to collecting statistics
>      if I can't see them, but well, I'd really like to see them please."
> 
> Having to specify the -v with the -p is wrong.

Sure!

> 
> One could have -p imply -v but I don't like that either.
> The way things were -p gave the basic profiling data
> and -p -v gave verbose profiling data.
> 
> I read in the patch submission from Stephane that the purpose
> of the patch was to make nrun.c behave like run.c.
> run.c is broken in so many ways, let's not use it as
> a guide for how to do things.

The sim_info() is used for several purposes. For several simulators, it is used
to print various information (not only profiling as in your case). Having this
information printed each time you run the simulator is not good too. In particular
I don't want to have such information printed when I run the gcc testsuite.

Now, I understand that -v is not the appropriate option. I guess a new flag
is necessary in the SIM_DESC to control the final call to sim_info().
Such flag should then be set when the profiling is activated, or when some
-print-sim-info-at-the-end nice option is specified.

I think this would solve your problem and mine.

By the way, is there any man page for nrun?

	Stephane

-----------------------------------------------------------------------
         Home                               Office
E-mail: stcarrez@worldnet.fr               Stephane.Carrez@sun.com
WWW:    http://home.worldnet.fr/stcarrez   http://www.sun.com
Mail:   17, rue Foucher Lepelletier        6, avenue Gustave Eiffel
        92130 Issy Les Moulineaux          78182 Saint Quentin en Yvelines
        France