This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Testsuite patches...
- To: Scott Bambrough <scottb at netwinder dot org>
- Subject: Re: RFA: Testsuite patches...
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Fri, 28 Jul 2000 14:47:27 -0400
- CC: GDB Patches Mail List <gdb-patches at sourceware dot cygnus dot com>
- Organization: Red Hat , Inc. - Toronto
- References: <39803B5C.9C31BB15@netwinder.org>
Scott Bambrough wrote:
>
> 2000-07-26 Scott Bambrough <scottb@netwinder.org>
>
> * linux-thread.c (linux_threads_pid_to_str): Change "Pid" to
> "process" to allow gdb.base/environ.exp to pass all tests.
> Change capitalization on "Thread" for consistency.
>
I forwarded the above change to the maintainers requesting their approval.
> 2000-07-26 Scott Bambrough <scottb@netwinder.org>
>
> * gdb.base/environ.exp: Run tests for all targets.
> * gdb.base/recurse.exp: Run tests for all targets.
>
These two are OK.
> * gdb.base/sect-cmd.exp: Run tests for all targets. Use
> 'section .text' clause for Linux in set section command
> test.
>
This is not. The expect code must be changed to memorize if the architecture
uses .text or CODE and use it subsequently.
> * gdb.base/so-impl-ld.exp: Added wildcard to
> handle the gnu-oldld case on ARM.
>
All right. Godd catch. Thanks.
> * gdb.base/so-indr-cl.exp: Run tests for *-*-linux-gnu*.
You must also add a comment (as is done in so-impl-ld.exp) explaining that this
is also known to run in Linux (version?). The comment there says it *must* be
a HP target and we will contradict it with the code.
> * gdb.base/watchpoint.exp (test_stepping): Clear xfail
> for ARM targets.
>
You are the boss here :-) Let's add this one.
Scott, you can either wait a bit for me to make the changes or, if you find
some spare cycles, do the changes yourself. We need to wait for the Linux thread
folks to authorize the change to linux-threads.c (which will probably be soon
anyways).
Thanks for the patch.
Regards,
Fernando
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@cygnus.com
2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311
Toronto, Ontario M4P 2C9 Fax: 416-482-6299