This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [PATCH RFA] Pascal language part 4: Changes to symfile.c
- To: Mark Kettenis <kettenis at wins dot uva dot nl>
- Subject: Re: [PATCH RFA] Pascal language part 4: Changes to symfile.c
- From: Pierre Muller <muller at cerbere dot u-strasbg dot fr>
- Date: Mon, 19 Jun 2000 12:57:27 +0200
- Cc: taylor at cygnus dot com, jimb at cygnus dot com, ezannoni at cygnus dot com, gdb-patches at sourceware dot cygnus dot com
- References: <200006191048.MAA24798@cerbere.u-strasbg.fr><200006191048.MAA24798@cerbere.u-strasbg.fr>
>A few comments on this one:
>
> * Isn't the ".inc" extension for Pascal "include" files? If so, I'm
> not sure whether the extension should be added, since C includes
> ("*.h") aren't mentioned either.
No, because pascal include file do indeed contain code,
whereas C header normally don't.
But I don't even know if this should not be changed now,
because inlined C++ code and be in the headers, no ?
Of course the second problem is that .H files can be for
raw C, C++ or objective C!
> * Please keep the formatting uniform. You try to line-up the
> "language_pascal"s but none of the other languages do that.
I will remove this alignment before committing this in all case,
thanks for this.
> * You might want to put your family name last in the ChangeLog entry,
> otherwise people may start to worry whether Muller Pierre and
> Pierre Muller are one and the same person or not :-).
Thanks for remind me of this!
Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99