This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: (patch) hpjyg15: hppah-nat.c & related


>You missed another alternative, which I'd tend to favor.
>
>1. Run intent on the gdb source files.  Submit that as a patch.  That should be
>   acceptable without problems.
>
>2. Apply the patch from wdb using whatever means are possible (patch -l ?).
>
>3. Re-run indent on the changed files.
>
>4. Submit the patch resulting from diffing the output of steps #1 and #3.

    This is very doable.  Painful as it may appear, it's more so in the
    steps involved than the actual overhead ... and I will definitely
    write a simple script to generate patch for #1 and #3 in one shot ...

>Yes, this is painful.  But it avoids introducing new formatting problems in
>the sources (in fact via step #1 it will tend to fix formatting problems that
>have slipped in accidentally).

    I agree.

>Of course we only need to go through this pain as we flush out your old
>patches.  Newer stuff should be done using GNU standards and this kind of
>painful process shouldn't be necessary.

    Since I'm 'chopping' changes apart to limit patch scope and
    'cooking' patches during patch testing cycles, the above steps are
    pretty much what should be done for my future patches as well.

- Jimmy Guo, guo@cup.hp.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]